flink time 01 #135
Merged
flink time 01 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpinegizmo
reviewed
Apr 25, 2025
There was a problem hiding this comment.
Great stuff! A few minor comments inline.
Overall, I think it is rather long, I feel some parts could be condensed, e.g. by writing it a bit less along the lines of stepping through all the obstacles yourself, avoiding some of the detours ("Oh no! I was wrong…or was I?".
This would make room for adding a section on handling late events where Flink actually can update previously closed windows for some time (that said, this is supported for DataStream, I'm not sure about Table/SQL).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.