strip trailing '.' from record name passed to DNS plugins to simplify…

… parsing logic (#584)
rmbolger · Nov 16, 2024 · d599243 · d599243
1 parent b516a54
commit d599243
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Posh-ACME/Public/Publish-Challenge.ps1 b/Posh-ACME/Public/Publish-Challenge.ps1
@@ -45,7 +45,7 @@ function Publish-Challenge {
 
         # call the function with the required parameters and splatting the rest
         Write-Debug "Calling $Plugin plugin to add $recordName TXT with value $txtValue"
-        Add-DnsTxt -RecordName $recordName -TxtValue $txtValue @PluginArgs
+        Add-DnsTxt -RecordName $recordName.TrimEnd('.') -TxtValue $txtValue @PluginArgs
 
     } else { # http-01 is the only other challenge type we support at the moment
 

diff --git a/Posh-ACME/Public/Unpublish-Challenge.ps1 b/Posh-ACME/Public/Unpublish-Challenge.ps1
@@ -45,7 +45,7 @@ function Unpublish-Challenge {
 
         # call the function with the required parameters and splatting the rest
         Write-Debug "Calling $Plugin plugin to remove $recordName TXT with value $txtValue"
-        Remove-DnsTxt -RecordName $recordName -TxtValue $txtValue @PluginArgs
+        Remove-DnsTxt -RecordName $recordName.TrimEnd('.') -TxtValue $txtValue @PluginArgs
 
     } else { # http-01 is the only other challenge type we support at the moment