Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_event_attendees restored, joined date for users corrected (= created date), and 400 error comment #71

Merged
merged 8 commits into from
Jul 9, 2020

Conversation

RickPack
Copy link
Collaborator

Forgive me, I need to be brief because of timelines. Please remind me if I forget to add more comments by July 4th
I believe all of these edits have been discussed in #67 except get_event_attendees.R. In get_event_attendees.R, I restored the returned rsvp_response that now works (maybe a prior Meetup API problem was fixed) and also show the bio now. This was needed for a presentation today (yikes).

RickPack added 3 commits June 22, 2020 19:14
Responding to rladies#67, this replaces the former Meetup API's use of "joined" with "created" to acquire "The time this member joined the Group, represented as milliseconds since the epoch" per https://www.meetup.com/meetup_api/docs/:urlname/members/#list.
…em (as of June 30, 2020: could be using get_event_attendees.R on an event not yet completed, seemingly a Meetup API bug).
@ledell ledell self-requested a review July 3, 2020 05:44
@ledell
Copy link
Member

ledell commented Jul 3, 2020

Hey @RickPack, thanks for the contribution! So this fully resolves #67?

If so, that's awesome and I'd invite you to add your name to end of the Authors section in the DESCRIPTION file as a contributor before I merge this!

      person(given = "Rick",
             family = "Pack",
             role = "ctb",
             email = "your@email.com")

@RickPack
Copy link
Collaborator Author

RickPack commented Jul 6, 2020

Thank you @ledell for inviting my addition as a contributor. Yes, this fully resolves #67. I added your kindly provided code to this PR so it should be ready to go. I hope you have a great week!

Copy link
Member

@ledell ledell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @RickPack!

@ledell ledell merged commit bc68cd4 into rladies:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants