Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currentColor Change Overrides Customized Color Settings #3954

Closed
yinanazhou opened this issue Feb 13, 2025 · 3 comments
Closed

currentColor Change Overrides Customized Color Settings #3954

yinanazhou opened this issue Feb 13, 2025 · 3 comments

Comments

@yinanazhou
Copy link
Contributor

The changes in this PR set path to use currentColor, which overrides the color settings in Neon (DDMAL/Neon#1289). Using !important to set colors could be a temporary workaround, but a better long-term solution should be explored.

Image

@rettinghaus
Copy link
Contributor

Before every single path had its own stroke attribute, which was rather unefficient. Perhaps you want to check your CSS? Why not take

svg > svg path { stroke: color; }

@lpugin
Copy link
Contributor

lpugin commented Feb 14, 2025

Or maybe

svg > svg path {
  color: rgb(230, 159, 0);
}

@yinanazhou
Copy link
Contributor Author

Thanks for the reply. I was able to find a workaround other than using !important (DDMAL/Neon#1293 for reference). I'm closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants