Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge label for iceberg tests & add auto labeler #20574

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Feb 21, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Signed-off-by: xxchan <xxchan22f@gmail.com>
Comment on lines 255 to +256
- label: "end-to-end iceberg sink v2 test"
if: build.pull_request.labels includes "ci/run-e2e-iceberg-sink-tests" || build.env("CI_STEPS") =~ /(^|,)e2e-iceberg-sink-tests?(,|$$)/
if: build.pull_request.labels includes "ci/run-e2e-iceberg-tests" || build.env("CI_STEPS") =~ /(^|,)e2e-iceberg-sink-tests?(,|$$)/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that previously we use ci/run-e2e-iceberg-sink-v2-tests only for main-cron, but not here... It's confusing.

I think only ci/run-e2e-iceberg-tests is enough

@xxchan xxchan requested a review from chenzl25 February 21, 2025 15:20
@xxchan xxchan enabled auto-merge February 21, 2025 15:24
@xxchan xxchan added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit e97b914 Feb 21, 2025
29 of 30 checks passed
@xxchan xxchan deleted the xxchan/ice-ci branch February 21, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants