Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iceberg): move scan from batch to connector #20567

Open
wants to merge 1 commit into
base: xxchan/ice-1
Choose a base branch
from

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Feb 21, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

refactor(iceberg): move scan from batch to connector

Add function , so the code can be shared by stream source.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan xxchan marked this pull request as ready for review February 21, 2025 10:17
@xxchan xxchan requested a review from a team as a code owner February 21, 2025 10:17
@xxchan xxchan requested review from hzxa21 and removed request for a team February 21, 2025 10:17
Copy link
Member Author

xxchan commented Feb 21, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Add function , so the code can be shared by stream source.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant