-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fips option for aws-lc #20287
Conversation
This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment |
# FIPS | ||
aws-lc-rs ={ version = "1.6", optional = true, default-features = false, features = [ | ||
"fips", | ||
] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not enable it by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong reason against doing so. It's simply because I didn't see any other product enabling this option by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for trying enable it by default.It does not bring us any additional cost I think.
Which images need to enable this? nightly? stable version? |
For now I guess there is no need to release with this option. But can we just build the image with the option and run a e2e test in our release pipeline? cc @lmatz |
One potential customer is requesting fips compliance and we may need to deliver the image, not 100% sure but could be soon but we can add the test first And if nothing serious happens after some testing period, I suggest we enable it by default in the future. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
add fips option for aws-lc
Manually tested in ci and locally.
Need to add a pipeline to build fips images
Checklist
Documentation
Release note