-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webhook): webhook waiting for persistency. #20164
Conversation
0e058d1
to
df3011a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 5561 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
2346 | 3 | 3212 | 0 |
Click to see the invalid file list
- src/batch/src/executor/fast_insert.rs
- src/frontend/src/scheduler/distributed/fast_insert.rs
- src/frontend/src/scheduler/fast_insert.rs
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
6acb271
to
01a0659
Compare
Another change in the newest commit:
Fix this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will we also use this stragey for the insert statement? cc @hzxa21
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This pr does several things:
task_service
calledfast_insert
(maybe should be calledlightweight_insert
).With this interface,
a. RW can insert dml data directly into tables without the complicated optimization process and batch execution process, which is more efficient.
b. the new interfaces allow callers to wait for persistency, which means, if enabled, the function call will only return after the data has been commited to persistency layer. To be specific, it will wait until the epoch when the insert happens has been commited in hummock.
One
ongoingrefactor: withFastInsertContext
saved as a map, we don't need to create a new sessionimpl every time anymore. After the communication with @st1page, pause for now.Two known bugs to fix:
alter table
.Checklist
Documentation
Release note