Reverses the effect of the Osc 1 Shape II value for SS (Shaped Saw Wave)

risgk · Aug 26, 2022 · c2b49ac · c2b49ac
1 parent f2dc61e
commit c2b49ac
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/DigitalSynthVRA8U/osc.h b/DigitalSynthVRA8U/osc.h
@@ -690,7 +690,7 @@ class Osc {
 
         int16_t temp;
         if (m_waveform[0] == WAVEFORM_1_S_SAW) {
-          temp = high_sbyte(+m_osc_gain_effective[0] * m_osc1_shape_ii_control);
+          temp = high_sbyte(+m_osc_gain_effective[0] * (128 - m_osc1_shape_ii_control));
           m_osc_gain_effective[3] = temp + temp;
         } else if (m_waveform[0] == WAVEFORM_1_PULSE) {
           temp = high_sbyte(-m_osc_gain_effective[0] * m_osc1_shape_ii_control);

diff --git a/README.md b/README.md
@@ -18,6 +18,7 @@
 
 ## Change History
 
+- v1.2.1: Reverses the effect of the Osc 1 Shape II value for SS (Shaped Saw Wave)
 - v1.2.0: Change the range of Osc 1 Shape from -64 -- +63 to 0 -- 127; Fix the comment on Osc 1 Shape II in VRA8-U CTRL
 - v1.1.1: Reduce noise in Chorus Mode M and S2
 - v1.1.0: Add SS (Shaped Saw Wave) to Osc 1 Wave; Add Osc 1 Shape II; Reduce noise when Chorus Delay Time changes; Improve Random Ctrl of VRA-8 CTRL not to change Amp Level; Improve notes for $$ and $$$; Other changes

diff --git a/VRA8-U-Parameter-List.md b/VRA8-U-Parameter-List.md
@@ -27,9 +27,9 @@
         - 127: Pulse Width 0% (min)
 - Osc 1 Shape II $$
     - Shaped Saw Wave
-        - 0: Saw 100% + Saw 100% (min)
+        - 0: Saw 100% + Saw 0% (max)
         - 64: Saw 100% + Saw 50%
-        - 127: Saw 100% + Saw 0% (max)
+        - 127: Saw 100% + Saw 100% (min)
     - Pulse Wave
         - 0: Pulse 100% = Saw 100% + Reverse Saw 100% (min)
         - 64: Pulse 50% + Saw 50% = Saw 100% + Reverse Saw 50%