Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACPERM rule removed for RV64 #549

Closed
tomaird opened this issue Feb 27, 2025 · 2 comments · Fixed by #550
Closed

ACPERM rule removed for RV64 #549

tomaird opened this issue Feb 27, 2025 · 2 comments · Fixed by #550

Comments

@tomaird
Copy link
Contributor

tomaird commented Feb 27, 2025

This PR: #507 intended to address what happened with M-bit encodings when Zcherihybrid was not implemented.
However it also removed rule 15 of acperm for RV64 unconditionally (i.e. regardless of whether Zcherihybrid exists or not). I believe this was unintentional, and the rule should still exist for RV64 when Zcherihybrid does exist.
@tariqkurd-repo
Copy link
Collaborator

Isn't this the same as making ASR depending on X only be for RV32?
Shouldn't they both be RV32 only, or neither?

@tariqkurd-repo
Copy link
Collaborator

I take that back - that's rule 14

@tariqkurd-repo tariqkurd-repo mentioned this issue Feb 28, 2025
Merged
arichardson pushed a commit that referenced this issue Mar 5, 2025
@tariqkurd-repo
Make M-bit dependent on X for RV64 (#550)
4423ecf 
Fixes #549

This affects spec version 0.9.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make M-bit dependent on X for RV64 tariqkurd-repo/riscv-cheri
2 participants
@tomaird @tariqkurd-repo