Skip to content

Commit

Permalink
ext-fwft: use the provided value in fwft_set(POINTER_MASKING_PMLEN)
Browse files Browse the repository at this point in the history
Using a greater value without supervisor approval is problematic,
because it could result in behavior that the supervisor cannot handle.

We've discussed an extra function with detection bitmask for this, but
decided to have the supervisor software loop over all possible values
and find one that works.  Luckily there are only two options right now.

There was also an attempt to add a note with a recommendation to
supervisor software writers, but the resulting discussion failed to
produce a satisfactory formulation and the fix is needed ASAP.

Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
  • Loading branch information
radimkrcmar authored and atishp04 committed Feb 18, 2025
1 parent 2b09fad commit c7d3d1f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/ext-firmware-features.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,7 @@ description. Upon system reset, global and local feature values are reset.
[cols="1,4"]
!===
! 0 ! Disable pointer masking for supervisor-mode.
! N ! Enable pointer masking for supervisor-mode with PMLEN >= N.
A call to `sbi_fwft_get()` returns the actual value of PMLEN.
! N ! Enable pointer masking for supervisor-mode with PMLEN = N.
!===
|===

Expand Down

0 comments on commit c7d3d1f

Please sign in to comment.