Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: don't insert preinserted space when not inline_preedit[draft] #1462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: don't insert preinserted space when not inline_preedit[draft] #1462

wants to merge 1 commit into from

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Jan 2, 2025 •
edited
Loading

close #1411

maybe fix some issues cause by preinserted space, #1144, #1106, #1407 #1416, #1326, #1231, iDvel/rime-ice#1043 and so on

lotem
lotem approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

試試唄。我看好你。

@fxliang
Copy link
Contributor Author

fxliang commented Jan 3, 2025

試試唄。我看好你。

有点问题，自动顶屏的时候有一点问题，还要再确认看看

@fxliang fxliang assigned fxliang and unassigned fxliang Jan 3, 2025
@fxliang fxliang changed the title refactor: don't insert preinserted space when not inline_preedit refactor: don't insert preinserted space when not inline_preedit[draft] Jan 3, 2025
@mirtlebot
Copy link

反馈一下：我自己合并此 PR，在本机 Windows 10 上，测试了大概十天以上，关嵌入预编辑区，在设计工具、代码编辑器、浏览器、IM 软件等软件上均无明显异常。

  • 注意到部分应用上无法定位候选框，此时开启嵌入模式，发现也无法定位。大概和此 PR 无关。
  • 注意到在 slack，chatgpt 某些编辑界面，有吃键的现象，开关嵌入模式，发现吃字现象无缓解，大概和 PR 无关。

@fxliang
Copy link
Contributor Author

fxliang commented Jan 26, 2025

反馈一下：我自己合并此 PR，在本机 Windows 10 上，测试了大概十天以上，关嵌入预编辑区，在设计工具、代码编辑器、浏览器、IM 软件等软件上均无明显异常。

  • 注意到部分应用上无法定位候选框，此时开启嵌入模式，发现也无法定位。大概和此 PR 无关。
  • 注意到在 slack，chatgpt 某些编辑界面，有吃键的现象，开关嵌入模式，发现吃字现象无缓解，大概和 PR 无关。

自动顶字的时候有问题

@lotem
Copy link
Member

lotem commented Jan 26, 2025

自动顶字的时候有问题

好難！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fxliang @mirtlebot @lotem