Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage to 90% #50

Open
richecr opened this issue May 15, 2023 · 2 comments
Open

Increase code coverage to 90% #50

richecr opened this issue May 15, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@richecr
Copy link
Owner

richecr commented May 15, 2023

Feature description::

Code coverage is currently only 87%, but with several files well below that coverage. The idea is to leave the overall coverage above 90% and also for each file.

image

Need:

This way we will have much better confidence about any future changes that are made to the code. Facilitating its evolution.

Implementation:

Continue test implementation as is.

@richecr richecr added enhancement New feature or request good first issue Good for newcomers labels May 15, 2023
@sunny-Ne5
Copy link

sunny-Ne5 commented Jun 1, 2023

Hi @richecr I'd like to give it a shot. Is duck_orm/model_manager.py a good starting point as it has the lowest coverage?
Also can you please tell me more about the approach followed in create_table function inside duck_orm/model_manager.py when I tried to write a test case for coverage it was giving errors.

@richecr
Copy link
Owner Author

richecr commented Jun 2, 2023

Hi @sunny-Ne5, it's great that you are interested in the project.

duck_orm/model_manager.py is a good start.

The create_table method is being removed from this project and migrated to duck-orm-cli to handle migrations in a separate project, so the method is not working. Thanks for letting me know, I'll remove the migrated code.

And I will be very happy to receive your contributions. And I will be very happy to receive your contributions. Therefore, if you prefer, you can test the other functions and ignore the ones: get_database, create_table, drop_table and _execute_sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants