Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnacondaWebUIWorkflow breaks terminal output #65

Open
velezd opened this issue Feb 17, 2023 · 1 comment
Open

AnacondaWebUIWorkflow breaks terminal output #65

velezd opened this issue Feb 17, 2023 · 1 comment

Comments

@velezd
Copy link
Collaborator

velezd commented Feb 17, 2023

AnacondaWebUIWorkflow is using virt-install command to start VM and to get console output. But virsh console switches the terminal in to raw mode and that breaks output of the whole pipeline. New lines do not return to the start.

This is not an issue if the output is redirected in to a file, eg. running in jenkins or GitHub CI.
And it can be workaround-ed but running Permian with /dev/null on stdin ./pipeline ... < /dev/null (Permian will create new pty).

@pholica
Copy link
Contributor

pholica commented Feb 21, 2023

This could be also resolved by introducing a singleton for "dummy" (input-less) PTY that could be created by https://python.readthedocs.io/en/stable/library/pty.html#pty.openpty as it's currently done in

_, pty_slave = pty.openpty()
(which could be eventually also removed).
This singleton slave pty could be then used in situations where some commands need to manipulate with pty but it's not needed to provide any input. And having one shared should also not have any negative impact on number of file descriptors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants