From 1f03e4386121f944bb50db5fd42414baa05dcbf3 Mon Sep 17 00:00:00 2001 From: Jianyong Wu Date: Mon, 31 Jul 2023 02:40:15 +0000 Subject: [PATCH] pe: Enhance debug report for update_mem_attrs When memory attributes cannot be updated due to misalignment with 4K or when the size is 0, the debug printout lacks sufficient clarity to indicate the issue. To enhance troubleshooting, it is crucial to generate an error log that explicitly states the failure to execute the expected action. This error log will be visible even when the debug level log is not enabled, thereby significantly reducing debugging time. Signed-off-by: Jianyong Wu --- pe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pe.c b/pe.c index e15b89f62..08aadf72a 100644 --- a/pe.c +++ b/pe.c @@ -476,7 +476,7 @@ update_mem_attrs(uintptr_t addr, uint64_t size, &before, efi_status); if (!IS_PAGE_ALIGNED(physaddr) || !IS_PAGE_ALIGNED(size) || size == 0) { - dprint(L"%a called on 0x%llx-0x%llx (size 0x%llx) +%a%a%a -%a%a%a\n", + perror(L"%a: Failed to update memory attrs on 0x%llx-0x%llx (size 0x%llx) +%a%a%a -%a%a%a as address or size does not align with 4K or size equals 0\n", __func__, (unsigned long long)physaddr, (unsigned long long)(physaddr + size - 1), (unsigned long long)size,