Don't use SeedRng some places where it isn't necessary #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedara90
reviewed
Feb 2, 2025
src/battle_pyramid.c
Outdated
Comment on lines
1000
to
1001
| for (i = 0; i < itemIndex; i++) | ||
| LocalRandom(&rand); |
There was a problem hiding this comment.
I'm trying to understand what's happening here.
Is it just advancing LocalRandom itemIndex times?
It feels like it's unnecessary, but it's what the previous behavior was too (which isn't a great judge to be fair).
There was a problem hiding this comment.
There are only four random seeds for each pyramid floor, but you can have up to 8 trainers on a given floor, so some seeds would need to be shared. It's burning random numbers so each pair of trainers does not (necessarily) give the same item; perhaps it isn't doing so in the most efficient way. I think I'll rewrite this chunk of code to work similarly but slightly differently.
hedara90
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I personally believe that reseeding the global random number generator(s) for local purposes is not a good idea, and Emerald does it when it would not have been necessary. This removes some of the places where this is done.
It also adds
u32 LocalRandom32(rng_value_t *); while one could argue thatLocalRandomdoesn't need to exist anymore, I like the idea that if for some reason the PRNG were to change again, the names of the functions people actually use would remain accurate.Feature(s) this PR does NOT handle:
Battle recordings and contests still set the global RNG seed even though they shouldn't need to change it permanently. I'll think about how to handle this.
Discord contact info
tertu