Fixed non-regional forms breeding incorrectly #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cawtds
reviewed
Jul 16, 2024
cawtds
reviewed
Jul 16, 2024
Sneed69
reviewed
Jul 16, 2024
|
I think this covers all the form inheritance cases. Since Tauros cannot be female in vanilla games there is no definite answer to the last case. Imo since Blaze and Aqua are two different forms of the same regional form, it should default to the female species as parent and ignore the everstone like in the Shellos case, therefore Kantonian Tauros would be the egg species. |
hedara90
added
category: pokemon
|
Finally solved the issue I was having with this. (it was parentslots which were confusing me at the time). Ready for review! |
Bassoonian
requested changes
Jan 1, 2025
|
Comments addressed and added Shellos test to make sure that the regional changes don't affect other form breeding |
|
Forgot to say, but ready for rereview |
Bassoonian
reviewed
Jan 29, 2025
|
Ready for re-review. |
Bassoonian
reviewed
Feb 2, 2025
This reverts commit 3e2f6f0.
Bassoonian
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to #4695
People who collaborated with me in this PR
@cawtds
Feature(s) this PR does NOT handle:
While it does add region constants, this PR doesn't handle multi-region support for now.
Discord contact info
AsparagusEduardo