Echoed Voice / Metronome (item) damage after Fake Out incorrectly increases

[moostoet]

Description

Echoed Voice and Metronome damage seem to increase even after Fake Out, where the consecutive move counter should not increase.

Pokemon:

Nosepass
Ability: Sturdy
Level: 20
Tera Type: Rock
EVs: 1 HP
Careful Nature
IVs: 22 HP / 13 Def / 23 SpA / 19 SpD / 20 Spe

• Thunder Wave
• Rest
• Bulldoze
• Spark

Lombre
Ability: Rain Dish
Level: 20
Tera Type: Water
EVs: 1 HP
Modest Nature
IVs: 29 HP / 11 Def / 3 SpA / 13 SpD / 8 Spe

• Mega Drain
• Astonish
• Fake Out
• Bubble Beam

Enemy Team:

Amaura @ Metronome
Ability: Refrigerate
Level: 18
Tera Type: Rock
EVs: 1 Atk
Modest Nature
IVs: 0 Atk

• Echoed Voice
• Mud Shot

Expected behavior:

• Amaura uses Mud Shot against a Lombre coming in on it (count should be 1).
• Lombre uses Fake out on Amaura (which wants to use Echoed Voice and selects it), which should reset it's count as it cannot make a move.
• Amaura uses Echoed Voice on Lombre. As this is the first instance of Echoed Voice being used, both the Echoed Voice and Metronome count should be at 1 and deal approximately 22% (13) HP damage. (Lombre in this instance has 59 HP).

This was tested on Smogon to ensure what the correct behavior should be.

Actual behavior:

• Amaura uses Mud Shot against a Lombre coming in on it (count should be 1).
• Lombre uses Fake out on Amaura (which wants to use Echoed Voice and selects it), which should reset it's count as it cannot make a move.
• Amaura uses Echoed Voice on Lombre and deals 36-44 HP damage, resulting in a way higher percentage than would be expected from it on a 1-count Metronome/Echoed Voice move.

To note:

• When Fake Out is not used as a move, the damage ranges seem to be within the expected parameters (e.g. if Lombre uses Mega Drain twice on Amaura).

What I think is happening:

sameMoveTurns is supposed to be cleared in two places:
 • When a battler switches in (or after a faint) via SwitchInClearSetData/FaintClearSetData, and
 • In Cmd_ppreduce if gCurrentMove isn’t equal to gLastResultingMoves or WasUnableToUseMove returns true.
 • Also in MOVEEND_SAME_MOVE_TURNS, if the move “failed” (or, more precisely, if gCurrentMove doesn’t equal gLastResultingMoves or if the move had no effect).

What I think is most likely is that somewhere in the flinch logic, it isn't properly handling the amount of moves that either Echoed Voice or Metronome have counted.

Version

1.10.2 (Latest release)

Upcoming/master Version

64c5113

Discord contact info

viridian.

[Bassoonian]

Fixed by #6167