-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to Latest Terraria Release #2
base: master
Are you sure you want to change the base?
Conversation
…ntil tmodloader is updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple questions.
README.md
Outdated
@@ -2,7 +2,7 @@ | |||
|
|||
[tModLoader] dedicated server | |||
|
|||
Terraria server 1.4.0.2 with tModLoader v0.11.7.1 | |||
Terraria server 1.4.0.2 with tModLoader v0.11.7.1 NOTE: This will not function until tmodloader is updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this note refer to? Is it related to releases on steam?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So It means do not merge this yet. When I wrote it I did not realize tmodloader has not yet added support for the new terraria 1.4 update. So all these changes will break until tmodloader updates, which from what ive read may take a while.
@@ -0,0 +1,18 @@ | |||
language: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used travis before. Does this push to docker hub or does travis have it's own private registry used for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have to set your environment variables you see referenced in the travis UI itself with your docker hub credentials. It does not have a local registry. This builds the container and pushes it, then tests it by pulling and running it.
Hi, I just wanna ask, does this PR means tmodLoader v0.11.7.1 only works with Terraria Server v1.4.0.2? I want to install Calamity, and it only supports Terraria 1.3.5.3 I think. If that's the case, maybe I should fork this for my private use |
My bad, I think I can build my custom image using |
This is just a proof of concept PR for when tmodloader supports Terraria 1.4.x, which it currently does not. |
added travis testing
updated to terraria 1.4.0.1 and tmodloader 0.11.7