Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add village chunk claim refunds (collaboration with zavdav) and fix README.md typo #6

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Add village chunk claim refunds (collaboration with zavdav) and fix README.md typo #6

merged 2 commits into from
Nov 15, 2024

Conversation

svgaming234
Copy link
Contributor

No description provided.

@RhysB RhysB requested a review from a team November 1, 2024 07:56
zavdav
zavdav requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@zavdav zavdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps it would be better to just multiply the price per chunk with the amount of claims minus 1 instead of checking for every chunk if it's the spawn chunk

a bit nitpicky, but check if fundamentals is enabled before doing any calculations

@svgaming234
Copy link
Contributor Author

svgaming234 commented Nov 3, 2024 •
edited
Loading

@zavdav The chunk claim amount is checked separately as @RhysB requested due to potential different prices in future JVillage updates
image

@zavdav
Copy link
Contributor

zavdav commented Nov 3, 2024

ah i see

@svgaming234 svgaming234 merged commit 09715dd into retromcorg:main Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zavdav zavdav zavdav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svgaming234 @zavdav