Add better home list with the /homes command (with zavdav) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve conflict when possible |
|
@RhysB Conflict resolved |
|
Just doing some testing, let me know @svgaming234 if you can merge after @Grassboii or @zavdav has reviewed this. Hoping to allow you guys to merge without my involvement. |
zavdav
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
@svgaming234 you don't actually need to pass an instance of Fundamentals to CommandHomes since you're using getInstance() for everything. other than that, everything looks good to me
Grassboii
approved these changes
Nov 2, 2024
|
@RhysB Still cannot merge, still says only people with write access to the repo can merge |
|
oh i can merge it now, i forgot to accept the invite to the org @RhysB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature by zavdav and SvGaming234