Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jporron filter type baseline correction #127

Closed
wants to merge 6 commits into from

Conversation

JPorron
Copy link
Contributor

@JPorron JPorron commented Apr 26, 2024

JPorron Medium: 115 Powered by Pull Request Badge

The process is modified to allow for it to be applied to different signal types, with different parameters.

The logic in the .rml file is:

<addProcess type="TRestRawBaseLineCorrectionProcess" name="blCorrection" value="ON" verboseLevel="info">
	<parameter name="channelTypes" value="tpc,veto"/>
    <parameter name="signalsRangeTpc" value="(4610,4900)"/>
    <parameter name="smoothingWindowTpc" value="75"/>
</addProcess>

The channel types are separated by a , and the new parameters add at the end the channel type they are applied for. If we wanted to add different parameters for veto type signals:

<addProcess type="TRestRawBaseLineCorrectionProcess" name="blCorrection" value="ON" verboseLevel="info">
	<parameter name="channelTypes" value="tpc,veto"/>
    <parameter name="signalsRangeTpc" value="(4610,4900)"/>
    <parameter name="smoothingWindowTpc" value="75"/>
    <parameter name="signalsRangeVeto" value="(4810,4950)"/>
</addProcess>

If not specified the default values are 75 for the smoothing window and (-1, -1) for the signals range.

@lobis lobis self-requested a review April 26, 2024 09:34
#include <TObjString.h>
#include <TRestRawReadoutMetadata.h>

using namespace std;
Copy link
Member

@lobis lobis Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In .cxx files you can include any namespace you want, this is good.

You can mark this comment as resolved, I made just ni case you were about to remove the namespace declarations from cxx files

@@ -69,6 +69,11 @@

#include "TRestRawBaseLineCorrectionProcess.h"

#include <TObjString.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use TObjString?

JPorron and others added 2 commits April 26, 2024 14:32
Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
@JPorron JPorron closed this Apr 29, 2024
@JPorron JPorron deleted the jporron-filter-type-baseline-correction branch April 29, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants