-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jporron filter type baseline correction #127
Conversation
#include <TObjString.h> | ||
#include <TRestRawReadoutMetadata.h> | ||
|
||
using namespace std; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In .cxx files you can include any namespace you want, this is good.
You can mark this comment as resolved, I made just ni case you were about to remove the namespace declarations from cxx files
@@ -69,6 +69,11 @@ | |||
|
|||
#include "TRestRawBaseLineCorrectionProcess.h" | |||
|
|||
#include <TObjString.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we use TObjString
?
Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
for more information, see https://pre-commit.ci
The process is modified to allow for it to be applied to different signal types, with different parameters.
The logic in the .rml file is:
The channel types are separated by a , and the new parameters add at the end the channel type they are applied for. If we wanted to add different parameters for veto type signals:
If not specified the default values are 75 for the smoothing window and (-1, -1) for the signals range.