Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow task ttl to be set to 0 #543

Merged
merged 7 commits into from
Feb 11, 2025

Fix wording

7df0727
Select commit
Loading
Failed to load commit list.
Merged

Allow task ttl to be set to 0 #543

Fix wording
7df0727
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 11, 2025 in 0s

56.06% (-0.05%) compared to 9694c87

View this Pull Request on Codecov

56.06% (-0.05%) compared to 9694c87

Details

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.06%. Comparing base (9694c87) to head (7df0727).

Files with missing lines Patch % Lines
internal/app/subsystems/api/grpc/task.go 0.00% 2 Missing and 1 partial ⚠️
internal/app/coroutines/claimTask.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   56.10%   56.06%   -0.05%     
==========================================
  Files         129      129              
  Lines       13928    13934       +6     
==========================================
- Hits         7815     7812       -3     
- Misses       5651     5659       +8     
- Partials      462      463       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.