Update egui to latest master #9103
Draft
+118
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
lucasmerlin
force-pushed
the
lucas/egui-popup-modal-update
branch
from
9b40cb7 to
200768b
Compare
emilk
added a commit
to emilk/egui
that referenced
this pull request
Feb 25, 2025
In Rerun, pressing `Cmd+S` brings up a save dialog using `rfd`, but we get not key-up event for the `S` key (in winit). This leads to `S` being mistakenly marked as down when we switch back to the app. This PR takes the safe route and marks all keys as up when an egui app loses focus. * Tested with rerun-io/rerun#9103
lucasmerlin
force-pushed
the
lucas/egui-popup-modal-update
branch
2 times, most recently
from
2ce720e to
7284f6b
Compare
|
Fixed! |
lucasmerlin
added
dependencies
lucasmerlin
force-pushed
the
lucas/egui-popup-modal-update
branch
from
b52f513 to
98266f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
I was curious how my work on egui menus and popups would work in rerun, so I gave it a try.
Findings so far
The new tooltip positioning works well unless we scroll in the scroll area. Maybe we should intersect the widget rect with the clip rect.Fixed!Screen.Recording.2025-02-21.at.09.30.39.mov