Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2252] Enable CI Checks on PRs and Restrict Deployment to Master #20

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

JoanneHing
Copy link
Contributor

@JoanneHing JoanneHing commented Feb 9, 2025

Part of #18 in Reposense Repository

Proposed commit message

Run checks on PRs and deploy only on master push

This PR updates the CI workflow to ensure that Install dependencies
and Generate report run on all PRs, while deployment to GitHub Pages
happens only on pushes to the master branch. This change ensures
that pull requests are properly tested before merging, preventing
unintended deployments from feature branches and improving 
CI reliability. 

@JoanneHing JoanneHing requested a review from gok99 February 9, 2025 08:01
@gok99 gok99 marked this pull request as ready for review February 9, 2025 08:44
@gok99 gok99 requested a review from CYX22222003 February 9, 2025 08:46
Copy link

@CYX22222003 CYX22222003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gok99
Copy link
Contributor

gok99 commented Feb 9, 2025

@JoanneHing Could you format the commit message to a maximum of 72 chars per line: https://se-education.org/guides/conventions/git.html

@JoanneHing
Copy link
Contributor Author

@JoanneHing Could you format the commit message to a maximum of 72 chars per line: https://se-education.org/guides/conventions/git.html

Sorry didn't realized that the text wrapper I used wasn't functioning correctly. Fixed!

@gok99 gok99 merged commit 283aba7 into reposense:master Feb 9, 2025
1 check passed
@JoanneHing JoanneHing self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants