[#2285] Split CI tasks #19
Conversation
… into add-ci-checks
test.sh
Outdated
| @@ -0,0 +1,5 @@ | |||
| if ! ls ./reposense-report | grep -q "^index.html$"; then | |||
There was a problem hiding this comment.
This feels a little bit superficial, and with extensive tests on the main reposense project, doesn't seem entirely necessary.
If there isn't something substantial here that isn't subsumed by the main reposense tests, let's remove this for now.
There was a problem hiding this comment.
This is my attempt to address the requirement of automating the testing of deployments mentioned in this issue. I am not sure whether the "testing" mentioned in the issue is referring to a pre-deployment or post-deployment testing.
There was a problem hiding this comment.
I think it refers to being able to test for things like empty reports in the deployed site (when it should not be).
However, the test here wouldn't be able to check for this, and it wouldn't be visible from the main repository. Let's add testing incrementally, and see if there something substantial to test in a separate PR.
- remove unnecessary paths - add checks for branches
Proposed commit message