Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleaning up helm values before install / upgrade #1834

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

sgalsaleh
Copy link
Member

What this PR does / why we need it:

Fixes an issue when cleaning up helm values before install / upgrade where []map[string]interface{} types weren't handled, which broke admin console upgrades in some scenarios.

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

pkg/helm/client.go Outdated Show resolved Hide resolved
pkg/helm/client.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 6, 2025

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-f4dc9d7" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-f4dc9d7?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@sgalsaleh sgalsaleh enabled auto-merge (squash) February 6, 2025 21:15
@sgalsaleh sgalsaleh merged commit d816151 into main Feb 6, 2025
66 checks passed
@sgalsaleh sgalsaleh deleted the fix-upgrading-admin-console-chart branch February 6, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants