Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notify get notifications #263

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Jan 5, 2024

Description

Implements WalletConnect/walletconnect-specs#183

Resolves # (issue)

How Has This Been Tested?

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

Copy link
Contributor

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as it reflects the spec and conflicts will be resolved.

Base automatically changed from chore/refactors to main January 5, 2024 15:37
@chris13524 chris13524 force-pushed the feat/notifyGetNotifications branch from 287fa21 to 9344ca5 Compare January 5, 2024 15:38
@chris13524 chris13524 force-pushed the feat/notifyGetNotifications branch from 9344ca5 to c940b6c Compare January 5, 2024 16:07
@chris13524 chris13524 merged commit b0f667b into main Jan 5, 2024
12 checks passed
@chris13524 chris13524 deleted the feat/notifyGetNotifications branch January 5, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants