Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor magic values #262

Merged
merged 1 commit into from
Jan 5, 2024
Merged

chore: refactor magic values #262

merged 1 commit into from
Jan 5, 2024

Conversation

chris13524
Copy link
Member

Description

Resolves # (issue)

How Has This Been Tested?

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 requested a review from geekbrother January 5, 2024 00:16
@chris13524 chris13524 self-assigned this Jan 5, 2024
@chris13524 chris13524 force-pushed the fix/left-join-scope branch from 47f2668 to 6ac7007 Compare January 5, 2024 04:22
Base automatically changed from fix/left-join-scope to main January 5, 2024 04:26
geekbrother
geekbrother approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris13524 chris13524 merged commit 42c35bd into main Jan 5, 2024
12 checks passed
@chris13524 chris13524 deleted the chore/refactors branch January 5, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekbrother geekbrother geekbrother approved these changes

Assignees

@chris13524 chris13524

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris13524 @geekbrother