feat: rate limiting #231
Merged
feat: rate limiting #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
reviewed
Nov 29, 2023
| @@ -539,6 +525,24 @@ pub async fn verify_identity( | |||
| }) | |||
| } | |||
|
|
|||
| fn parse_cacao_statement(statement: &str, domain: &str) -> Result<AuthorizedApp> { | |||
There was a problem hiding this comment.
should be in a different PR as it seems is not related to the rate limiting
There was a problem hiding this comment.
It's related because the rate limit prevents more than 5 /notify calls in a single second, and the tests all use the same project ID. So had to refactor the type of tests to allow them to pass. This was also tech-debt already.
3 tasks
geekbrother
approved these changes
Dec 8, 2023
…into feat/rate-limiting
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds rate limiting.
Attempt refactoring of notify endpoint to reduce complexityRate limit data export for each endpoint call, containing the project and remaining tokensResolves #14
How Has This Been Tested?
Automated tests
Due Diligence