Fix ci ruby version #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignaciosy
commented
Jan 17, 2025
hunchr
reviewed
Jan 18, 2025
simon-isler
reviewed
Jan 24, 2025
simon-isler
approved these changes
Jan 24, 2025
To prevent breaking auto-updates such as this one in the future, we now push the test suite gemlock files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like ruby-version
3.0was cast to int within the matrix definition, and therefore ran the test suite asruby-3(leading to use 3.4.xinstead of3.0.x`).Then, now that we are actually using ruby 3.0, other compatibility issues arose, for which the CI and Appraisals have been updated as mentioned in the comments.