-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http): Switch to memory cache provider #33901
feat(http): Switch to memory cache provider #33901
Conversation
…cache-provider-switch
…-cache-provider-switch
…-cache-provider-switch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will test first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you summarize all the cases where http memcache is still being explicitly enabled in this PR (seems to be within platform code) and we evaluate whether we're better to add platform-level caching (e.g. of PR lists) instead of relying on http-level? Maybe you can do this through inline PR comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a significant reduction in the number of http requests which we cache in memory. This should apply especially to datasource requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running again on renovate-reproductions/renovate2
, I still get this:
DEBUG: Cache fallback URLs (repository=renovate-reproductions/renovate2)
"count": 4,
"hits": {
"https://api.github.com/repos/yarnpkg/berry": {
"callsite": "async Object.getReleaseNotesMd (/home/rhys/src/github/renovatebot/renovate/lib/workers/repository/update/pr/changelog/github/index.ts)",
"count": 1
},
"https://api.github.com/repos/yarnpkg/berry/git/blobs/3e96b54ffe13ba43b83ee1844a3ba37aeb4f77f8": {
"callsite": "async Object.getReleaseNotesMd (/home/rhys/src/github/renovatebot/renovate/lib/workers/repository/update/pr/changelog/github/index.ts)",
"count": 1
},
"https://api.github.com/repos/renovate-reproductions/renovate2/commits/renovate/main-yarn-monorepo/check-runs?per_page=100": {
"callsite": "async Proxy.getBranchStatus (/home/rhys/src/github/renovatebot/renovate/lib/modules/platform/github/index.ts)",
"count": 1
},
"https://api.github.com/repos/renovate-reproductions/renovate2/commits/renovate/main-mkdocs-material-9.x/check-runs?per_page=100": {
"callsite": "async Proxy.getBranchStatus (/home/rhys/src/github/renovatebot/renovate/lib/modules/platform/github/index.ts)",
"count": 1
}
}
LGTM, though needs a conflict resolution |
# Conflicts: # lib/modules/platform/gitlab/index.ts
🎉 This PR is included in version 39.213.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Make caching of GET/HEAD HTTP requests disabled by default.
When it's needed, the
memCacheProvider
is be used.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: