update cdo call (#141)

* update cdo call * tweaked ERA5 preprocessor * Update whats_new.rst
remo-rcm · Oct 19, 2023 · c506916 · c506916
1 parent 71640dc
commit c506916
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/docs/whats_new.rst b/docs/whats_new.rst
@@ -15,6 +15,7 @@ Internal Changes
 ~~~~~~~~~~~~~~~~
 
 - Fix SST interpolation and extrapolation for CF preprocessor (:pull:`140`).
+- Fix ERA5 cmorizer subprocess call (:pull:`141`).
 
 v0.6.0 (25 August 2023)
 -----------------------

diff --git a/pyremo/preproc/era5.py b/pyremo/preproc/era5.py
@@ -323,7 +323,12 @@ def gfile(self, date, path=None, expid=None, filename=None):
         call = f"cdo {self.options} invertlat {merge} {filename}"
         print(f"execute: {call}")
 
-        output = subprocess.Popen(call, shell=True, stdout=subprocess.PIPE)
+        subprocess.run(
+            call.split(),
+            check=True,
+            shell=False,
+        )
+        # stdout, stderr = process.communicate()
 
-        return output
+        return filename
         # return self.cdo.invertlat(options=self.options, input=merge, output=filename)