Update sequencer #52
Open
Update sequencer #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eagle941
force-pushed
the
update_sequencer
branch
18 times, most recently
from
24603df to
131ee48
Compare
Eagle941
force-pushed
the
update_sequencer
branch
5 times, most recently
from
b556265 to
d7b324d
Compare
iamrecursion
requested changes
Oct 22, 2024
Comment on lines
+3
to
+5
| LLVM_SYS_181_PREFIX = "/usr/lib/llvm-18/" | ||
| MLIR_SYS_180_PREFIX = "/usr/lib/llvm-18/" | ||
| TABLEGEN_180_PREFIX = "/usr/lib/llvm-18/" |
There was a problem hiding this comment.
I have concerns about just requiring the user to have this built and installed. You could consider a nix-based approach like we use in llvm-to-cairo?
There was a problem hiding this comment.
The script dependencies.sh performs the installation of llvm-18 for users that don't have it installed
| @@ -0,0 +1,64 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Please comment this script.
Eagle941
force-pushed
the
update_sequencer
branch
from
d7b324d to
3223795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
blockifierreplacing it withsequencer.