Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpc client optimisations #47

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Rpc client optimisations #47

merged 8 commits into from
Oct 2, 2024

Conversation

Eagle941
Copy link
Contributor

@Eagle941 Eagle941 commented Sep 30, 2024

This PR introduces the following changes:

  • Removed nightly from CI because it's not required
  • Added result of chain_id to OnceCell
  • Added result of block_number to OnceCell
  • Added BlockHeader to the return of starknet_get_block_with_receipts to save a call to starknet_get_block_with_tx_hashes

This closes #38

@Eagle941 Eagle941 force-pushed the rpc_client_refactoring branch from 332dd08 to f9dfa55 Compare September 30, 2024 20:57
- Added lazy_static for chain_id and latest_block_number
- Removed call to block_header
@Eagle941 Eagle941 force-pushed the rpc_client_refactoring branch 3 times, most recently from f984a3f to 4ac710f Compare October 1, 2024 10:06
@Eagle941 Eagle941 changed the title Rpc client refactoring Rpc client optimisations Oct 1, 2024
@Eagle941 Eagle941 requested a review from iamrecursion October 1, 2024 22:40
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good stuff, but a few changes needed.

README.md Show resolved Hide resolved
starknet-replay/src/storage/mod.rs Outdated Show resolved Hide resolved
starknet-replay/src/storage/rpc/rpc_client.rs Show resolved Hide resolved
starknet-replay/src/storage/rpc/rpc_client.rs Show resolved Hide resolved
starknet-replay/src/storage/rpc/rpc_client.rs Show resolved Hide resolved
starknet-replay/src/storage/rpc/rpc_client.rs Show resolved Hide resolved
starknet-replay/src/storage/rpc/rpc_client.rs Show resolved Hide resolved
starknet-replay/src/storage/rpc/rpc_client.rs Show resolved Hide resolved
starknet-replay/src/storage/rpc/rpc_client.rs Show resolved Hide resolved
starknet-replay/src/storage/rpc/rpc_client.rs Show resolved Hide resolved
@Eagle941 Eagle941 force-pushed the rpc_client_refactoring branch from db3561c to 2caf79b Compare October 2, 2024 20:28
@Eagle941 Eagle941 force-pushed the rpc_client_refactoring branch from 2caf79b to 9909090 Compare October 2, 2024 20:32
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Eagle941 Eagle941 merged commit 441811a into main Oct 2, 2024
5 checks passed
@Eagle941 Eagle941 deleted the rpc_client_refactoring branch October 2, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement caching of RPC responses
2 participants