-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of official Starknet client #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced manual RPC client with `starknet-rs` client.
Replaced manual RPC client with `starknet-rs` client. Updated blockifier dependency Updated blockifier dependency
Eagle941
force-pushed
the
starknet_client
branch
2 times, most recently
from
August 14, 2024 21:36
ce50b4e
to
4770414
Compare
Eagle941
force-pushed
the
starknet_client
branch
2 times, most recently
from
August 14, 2024 22:11
3042315
to
1afc65f
Compare
This is due to incompatibility of dependency `blockifier` with rust 1.80.0 or higher.
Eagle941
force-pushed
the
starknet_client
branch
from
August 14, 2024 22:35
1afc65f
to
59fb8a9
Compare
Eagle941
force-pushed
the
starknet_client
branch
from
September 8, 2024 22:20
b03e549
to
81a4960
Compare
Eagle941
force-pushed
the
starknet_client
branch
from
September 20, 2024 17:21
81a4960
to
0fb7bdf
Compare
Eagle941
force-pushed
the
starknet_client
branch
from
September 22, 2024 22:01
d1a2102
to
9e2861c
Compare
Eagle941
force-pushed
the
starknet_client
branch
from
September 22, 2024 23:03
9e2861c
to
9f03e49
Compare
Eagle941
force-pushed
the
starknet_client
branch
from
September 25, 2024 21:53
a50ed4e
to
f11667b
Compare
iamrecursion
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, but needs some re-engineering in places and some additional documentation.
Eagle941
force-pushed
the
starknet_client
branch
from
September 27, 2024 18:53
d25fe7f
to
f6de68a
Compare
Eagle941
force-pushed
the
starknet_client
branch
from
September 30, 2024 00:22
9bb5249
to
9fabeec
Compare
Eagle941
force-pushed
the
starknet_client
branch
from
September 30, 2024 00:22
9fabeec
to
6a8b987
Compare
Eagle941
force-pushed
the
starknet_client
branch
from
September 30, 2024 01:16
56c7555
to
e8ff69c
Compare
iamrecursion
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the hand crafted Starknet RPC client with the official RPC client from crate
starknet_providers
.Also, the Cairo dependencies are updated to
v2.7.0
and blockifier dependency is updated to use theVisitedPcs
trait.