Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of official Starknet client #46

Merged
merged 17 commits into from
Sep 30, 2024
Merged

Use of official Starknet client #46

merged 17 commits into from
Sep 30, 2024

Conversation

Eagle941
Copy link
Contributor

@Eagle941 Eagle941 commented Aug 14, 2024

This PR replaces the hand crafted Starknet RPC client with the official RPC client from crate starknet_providers.

Also, the Cairo dependencies are updated to v2.7.0 and blockifier dependency is updated to use the VisitedPcs trait.

Replaced manual RPC client with `starknet-rs` client.
Replaced manual RPC client with `starknet-rs` client.

Updated blockifier dependency

Updated blockifier dependency
@Eagle941 Eagle941 force-pushed the starknet_client branch 2 times, most recently from ce50b4e to 4770414 Compare August 14, 2024 21:36
@Eagle941 Eagle941 force-pushed the starknet_client branch 2 times, most recently from 3042315 to 1afc65f Compare August 14, 2024 22:11
This is due to incompatibility of dependency `blockifier` with rust
1.80.0 or higher.
@Eagle941 Eagle941 marked this pull request as ready for review September 20, 2024 17:13
@Eagle941 Eagle941 changed the title Starknet client Use of Starknet client Sep 25, 2024
@Eagle941 Eagle941 changed the title Use of Starknet client Use of official Starknet client Sep 25, 2024
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, but needs some re-engineering in places and some additional documentation.

Cargo.toml Show resolved Hide resolved
starknet-replay/src/storage/rpc/mod.rs Outdated Show resolved Hide resolved
starknet-replay/src/storage/rpc/transaction.rs Outdated Show resolved Hide resolved
@Eagle941 Eagle941 merged commit 0d63282 into main Sep 30, 2024
4 checks passed
@Eagle941 Eagle941 deleted the starknet_client branch September 30, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants