fix(sdk): Remove use of android id as unique identifier #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarchaud
approved these changes
Jul 19, 2024
Erebe42
force-pushed
the
fix/remove-android-id
branch
3 times, most recently
from
382f32a to
7db1a9c
Compare
Erebe42
force-pushed
the
fix/remove-android-id
branch
from
7db1a9c to
4a86405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I choose to remove the use of ANDROID_ID to follow the recommandation and the real use.
First, ANDROID_ID is always returning a constant, but is a mean to fetch the real unique ID.
(cf https://stackoverflow.com/questions/26244512/android-provider-settings-secure-android-id-returns-android-id)
By using the solution on this stackoverflow post, we have a warning cause the use of this method is not recommanded.
We should follow this documentation:
https://developer.android.com/identity/user-data-ids
And that is already done by using the google or amazon advertising ID.
So the fallback, if the client don't implement either of those library, is to generate a random string and store it.