feat: add importer for Digital Credit Union #89
Conversation
|
Nice, thanks! For csv importers, it's far more important to have unit tests (compared to ofx), so would you mind adding at least a couple lines? It's simple: |
|
Yeah, no problem. Would you mind if I pulled in another dependency, at least as dev dep? (I try, whenever possible, to add hypothesis tests if I'm going to write unit tests -- in addition to a static test.) |
|
Sure, dev dependencies are fine. |
|
@redstreet, I ended up not using hypothesis after all. I wrote up a test, but it really is testing beancount more than it's testing the importer, since it's making sure a series of random transactions that balance before import, balance after import. Juice isn't really worth the squeeze. |
|
Makes sense, and sounds good. If you don't mind addressing the comment above about |
I'm sorry, I must be blind; I don't see anything about USD above. The only comment I see on the code is the ofx => csv one. |
Drat, completely my bad, sorry! Github requires separately hitting a "submit review" as a second step when adding a comment as a part of a review (as opposed to adding a freestanding comment). This is non-obvious and not at all the first time I've been tripped up by it. It should be visible now. |
This adds a CSV importer for Digital Federal Credit Union (DCU), the 18th largest credit union in the United States (by total assets under management). Unfortunately, DCU doesn't offer OFX exports, so this is the best we can do.
Ah yes, I've been bitten by this one myself a couple of times. Change made! |
|
Awesome, thank you! |
|
Merged |
This adds a CSV importer for Digital Federal Credit Union (DCU), the 18th largest credit union in the United States (by total assets under management). Unfortunately, DCU doesn't offer OFX exports, so this is the best we can do.