Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandBuilder#generate method is called twice by us to waste #405

Closed
supercaracal opened this issue Nov 17, 2024 · 0 comments · Fixed by #406
Closed

CommandBuilder#generate method is called twice by us to waste #405

supercaracal opened this issue Nov 17, 2024 · 0 comments · Fixed by #406
Assignees
@supercaracal

Comments

@supercaracal
Copy link
Member

supercaracal commented Nov 17, 2024 •
edited
Loading

  • Every single call
  • Pipeline
  • Transaction
  • PubSub
  • SCAN

It consumes a wasting time of approximately 4% in the processing time. The normalization of the command passed by user should be done in our public methods side and should be skipped in internal raw clients side.
@supercaracal supercaracal changed the title Some features call the CommandBuilder#generate method twice Some features are calling the CommandBuilder#generate method twice to waste Nov 17, 2024
@supercaracal supercaracal self-assigned this Nov 17, 2024
@supercaracal supercaracal changed the title Some features are calling the CommandBuilder#generate method twice to waste CommandBuilder#generate method is calling twice to waste Nov 17, 2024
@supercaracal supercaracal changed the title CommandBuilder#generate method is calling twice to waste CommandBuilder#generate method is called twice to waste Nov 17, 2024
@supercaracal supercaracal changed the title CommandBuilder#generate method is called twice to waste CommandBuilder#generate method is called twice by us to waste Nov 17, 2024
@supercaracal supercaracal linked a pull request Nov 17, 2024 that will close this issue
perf: command builder shouldn't be called multiple times #406
Merged
@supercaracal supercaracal mentioned this issue Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supercaracal supercaracal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: command builder shouldn't be called multiple times supercaracal/redis-cluster-client
1 participant
@supercaracal