-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add basic per-user rate-limiting #5
Conversation
/cc @csams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nits, otherwise this looks good!
Co-Authored-By: Christopher Sams <csams@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
This adds basic per-user rate-limiting, which can be tested by running alongside a sharded-test-server (on a different port to the existing proxy instance), e.g:
Note
.cps-front-proxy/mapping.yaml
is just a copy of the KCP file, but with relative paths replaced with absolute onesWe can then see rate-limiting working here with the default
ratelimit-burst-limit
(5) we see something like this: