Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README and AAP_EXTRA_VARS in builder role examples #467

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README and AAP_EXTRA_VARS in builder role examples #467

wants to merge 2 commits into from

Conversation

mallmen
Copy link

@mallmen mallmen commented Feb 19, 2025

Description

README.md and AAP_EXTRA_VARS.md updated to remove single quotes from groups definition in builder_compose_customizations examples.

FIXES: Issue 466

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ x] Documentation update
  • Tests update
  • Refactor

Checklist

  • Added changelog fragment
  • Tests exist for affected features covering positive and negative scenarios

Mike Allmen added 2 commits February 19, 2025 11:43
In the sections where builder_compose_customizations examples are given,
111d5e3 
the groups entry is enclosed in single quotes which makes the definition
of groups a string instead of a list.  If the example is used as is, the
blueprint fails to push after creation.  This removes the single quotes
where groups is defined in the examples here.
In the sections where builder_compose_customizations examples are giv…
41a6e92 
…en, the groups entry is enclosed in single quotes which makes the definition of groups a string instead of a list. If the example is used as is, the blueprint fails to push after creation. This removes the single quotes where groups is defined in the examples here.
@mergify mergify bot added the waiting for review Pull request is ready for review label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxamillion maxamillion Awaiting requested review from maxamillion maxamillion is a code owner

@thom-at-redhat thom-at-redhat Awaiting requested review from thom-at-redhat thom-at-redhat is a code owner

@de1987 de1987 Awaiting requested review from de1987 de1987 is a code owner

@resoluteCoder resoluteCoder Awaiting requested review from resoluteCoder resoluteCoder is a code owner

@matoval matoval Awaiting requested review from matoval matoval is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
waiting for review Pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mallmen