Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue when password is in a survey of WF node and schedule #922

Merged

Conversation

przemkalit
Copy link
Contributor

What does this PR do?

Today I've notice encrypted value inside the extra_data, when there is a value inside the workflow node, then when the object is imported the dispatch is failing.

How should this be tested?

  1. Create a JT with survey that has required password variable.
  2. Create a WF and add JT to the WF, fill the variable password as it is required value.
  3. Export the objects.
  4. Import the objects

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

N/A

@przemkalit przemkalit changed the title fix: issue when password is in survey of WF node fix: issue when password is in a survey of WF node Oct 3, 2024
@przemkalit
Copy link
Contributor Author

I did find the same issue in the schedules.

@przemkalit przemkalit changed the title fix: issue when password is in a survey of WF node fix: issue when password is in a survey of WF node and schedule Oct 3, 2024
Copy link
Contributor

@ivarmu ivarmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivarmu ivarmu enabled auto-merge (squash) October 3, 2024 12:50
@djdanielsson djdanielsson disabled auto-merge October 3, 2024 13:51
@djdanielsson djdanielsson merged commit 6ef0999 into redhat-cop:devel Oct 3, 2024
9 of 13 checks passed
przemkalit added a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
…at-cop#922)

* fix: issue when password is in survey of WF node

* fix: encrypted for schedules

* fix: proper changelog

---------

Co-authored-by: Przemyslaw Kalitowski <przemyslaw@kalitowski.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants