possible fix for when survey_spec_contents.name is not defined #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennysh
requested review from
silvinux,
ivarmu and
adonisgarciac
as code owners
|
it duplicates #51 |
lennysh
deleted the
lennysh-possible-fix-survey_spec_contents-name-is-not-defined
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
So, there may be a better way to fix it, but this fixed it for me. All of my templates that didn't have any survey questions were failing because the dict item
spec_itemdidn't havename(line 213). I didn't have an issue in 2.4, but did as soon as I used this new role in 2.5. I don't know why the exiting| length > 0wasn't enough.How should this be tested?
For me, it just took me using it against job_templates that did NOT have ANY survey questions:
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc
N/A