exclude vllm changes from validation and upload #27
Conversation
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
There was a problem hiding this comment.
lgtm
A minor comment is if we would like to have something more dynamic in case we add more images like this in the future. So for example we could check if prevdir is in a list of strings (or if we don't plan to add more images I feel the current approach is sufficient).
There was a problem hiding this comment.
lgtm. +1 on what @thepetk said about having some type of store that has all excluded paths (similar to our tests for the registry stacks). I think just having an issue open for tracking is sufficient and it doesn't need to be included in this PR
yeah I thought about a list, but i did this quickly before logging off and i didnt want to over engineer it lol. I think if we have more exclusions in the future, we can make it a list but for now i will merge it |
What does this PR do?:
excludes vllm model server images from validation and upload due to the sheer size of the images. For example, if you are building a vllm image of 5Gi, the CI is going to run out of storage.
Which issue(s) this PR fixes:
N/A
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer: