This repository is currently being migrated. It's locked while the migration is in progress.
-
Notifications
You must be signed in to change notification settings - Fork 179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89fba2b
to
24af701
Compare
We're hitting |
0bd9fa1
to
8a9d734
Compare
These caused tests to hang under Python 3.13.
redloaf
approved these changes
Dec 20, 2024
- name: Install temporary Python 3.13 build dependencies | ||
if: ${{ matrix.python-version == '3.13' }} | ||
run: | | ||
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call me old fashioned, but it seems like a good idea to install a specific version and verify checksums.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 yeah how long do we expect this workaround to be in place?
scotthew1
approved these changes
Dec 20, 2024
- name: Install temporary Python 3.13 build dependencies | ||
if: ${{ matrix.python-version == '3.13' }} | ||
run: | | ||
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 yeah how long do we expect this workaround to be in place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13 was released on 2024-10-07. This PR adds support to Baseplate.py for services running 3.13.
Merge checklist
https://github.com/psycopg/psycopg2/pull/1695
https://github.com/confluentinc/confluent-kafka-python/issues/1768
https://github.com/sdispater/pendulum/issues/844
cgi
import:https://github.com/Pylons/webob/issues/437
legacy-cgi
package: https://pypi.org/project/legacy-cgi/grpcio
needs a new releaseActually we just need 1.66.2.1.67.0
has the fix but it's not on PyPI yet: https://pypi.org/project/grpcio/#history (1.67.0rc1 doesn't have the fix)