-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
| [![PR App][icn]][demo] | Fix RM-9018 RM-9022 | | :--------------------: | :-----------------: | ## 🧰 Changes Supports Variables and GlossaryItems! Ok, so this PR only has a small 🤏 code change for those components. We just have to format the correct jsx in the editor for this to work, _I think_. This PR does - rename tests from `flavored-*` to `*` - removes `yaml` from the top of the doc - runs the variable browser test ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
- Loading branch information
1 parent
e0f53e4
commit aeebd7c
Showing
33 changed files
with
177 additions
and
16 deletions.
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
Binary file modified
BIN
-8.72 KB
(76%)
...regression-tests-rdmd-syntax-renders-callout-tests-without-surprises-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.53 KB
(93%)
...ual-regression-tests-rdmd-syntax-renders-vars-test-without-surprises-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { render, screen } from '@testing-library/react'; | ||
import React from 'react'; | ||
|
||
import { run, compile } from '../../index'; | ||
|
||
describe('GlossaryItem', () => { | ||
it('renders a glossary item', async () => { | ||
const md = `<GlossaryItem term="parliament" />`; | ||
const Content = await run(compile(md)); | ||
render(<Content />); | ||
|
||
expect(screen.getByText('parliament')).toBeVisible(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { render, screen } from '@testing-library/react'; | ||
import React from 'react'; | ||
|
||
import { run, compile } from '../../index'; | ||
|
||
describe('Variable', () => { | ||
it('render a variable', async () => { | ||
const md = `<Variable variable="name" />`; | ||
const Content = await run(compile(md)); | ||
render(<Content />); | ||
|
||
expect(screen.getByText('NAME')).toBeVisible(); | ||
}); | ||
}); |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,21 @@ | ||
--- | ||
title: "Variable Tests" | ||
title: 'Variable Tests' | ||
category: 5fdf9fc9c2a7ef443e937315 | ||
hidden: true | ||
--- | ||
<<defvar>> and `<<defvar>>` and: | ||
|
||
<Variable variable="defvar" /> and `<Variable variable="defvar" />` and: | ||
|
||
``` | ||
<<defvar>> | ||
<Variable variable="defvar" /> | ||
``` | ||
|
||
and | ||
|
||
```js | ||
const xyz = "<<defvar>>"; | ||
const xyz = "<Variable variable="defvar" />"; | ||
``` | ||
|
||
## Glossary Items | ||
|
||
<GlossaryItem term="demo" /> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters