Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load failure for encrypted EPUB3 Navigation Document, Content Filter Chain out of date with late registration of Content Module #262

Open
danielweck opened this issue Oct 20, 2016 · 4 comments
Open

Load failure for encrypted EPUB3 Navigation Document, Content Filter Chain out of date with late registration of Content Module #262

danielweck opened this issue Oct 20, 2016 · 4 comments
Assignees
@danielweck
Labels
difficulty:Dev func:Navigation func:Packaging platform:Android priority:High type:Enhancement

Comments

@danielweck
Copy link
Member

danielweck commented Oct 20, 2016 •
edited
Loading

Support for encrypted NavDoc was introduced here:
bdcbdc6#diff-db92dd69cdd7ce3a59e70ae293050d98
...but this only works for EPUB Containers/Packages loaded (unpacked) after the Content Filter registration. Unfortunately the LCP Content Module sub-system requires loading of the License which occurs after the EPUB is opened, so the Content Filter registration occurs too late. As a result the Nav Doc cannot be parsed because of its scrambled encrypted byte stream. LibXml does not crash (fails silently).

I am fixing this now (update: fixed, see comment below)

Also see:
#221
danielweck added a commit that referenced this issue Oct 20, 2016
@danielweck
updated API for skipping loading of (potentially) encrypted EPUB3
d42485f 
Navigation
Document before the Content Filters are registered (otherwise libXml
silently fails to parse XHTML, and the ReadiumSDK internal navigation data
model is empty (until the next open() as the Filter Manager is a
singleton)). See: #262
@danielweck
Copy link
Member Author

Fixed in feature/lsd branch:
d42485f

@danielweck
Copy link
Member Author

On the client side (LCP content module): readium/readium-lcp-client@d354426

@danielweck
Copy link
Member Author

@mmenu-mantano @jmgeffroy CC-ing you guys as I know you looked into the encrypted NavDoc issue :)

@danielweck danielweck mentioned this issue Jan 12, 2017
Closed
@danielweck
Copy link
Member Author

Reminder, fixed in feature/lcp:
d42485f

...and recently API slightly changed to address the same problem with Media Overlays (encrypted SMIL files):
24e004a

See related issue:
#272

@danielweck danielweck self-assigned this Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielweck danielweck

Labels
difficulty:Dev func:Navigation func:Packaging platform:Android priority:High type:Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielweck @rkwright