Remove superfluous http status code setting

readium · Mar 22, 2020 · b6f04a8 · b6f04a8
1 parent 646793a
commit b6f04a8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/frontend/api/dashboard.go b/frontend/api/dashboard.go
@@ -41,7 +41,6 @@ func GetDashboardInfos(w http.ResponseWriter, r *http.Request, s IServer) {
 		if err = enc.Encode(pub); err == nil {
 			// send json of correctly encoded user info
 			w.Header().Set("Content-Type", api.ContentType_JSON)
-			w.WriteHeader(http.StatusOK)
 			return
 		}
 
@@ -68,7 +67,6 @@ func GetDashboardBestSellers(w http.ResponseWriter, r *http.Request, s IServer)
 		if err = enc.Encode(pub); err == nil {
 			// send json of correctly encoded user info
 			w.Header().Set("Content-Type", api.ContentType_JSON)
-			w.WriteHeader(http.StatusOK)
 			return
 		}
 

diff --git a/frontend/api/publication.go b/frontend/api/publication.go
@@ -94,9 +94,8 @@ func GetPublication(w http.ResponseWriter, r *http.Request, s IServer) {
 	if pub, err := s.PublicationAPI().Get(int64(id)); err == nil {
 		enc := json.NewEncoder(w)
 		if err = enc.Encode(pub); err == nil {
-			// send json of correctly encoded user info
+			// send a json serialization of the publication
 			w.Header().Set("Content-Type", api.ContentType_JSON)
-			w.WriteHeader(http.StatusOK)
 			return
 		}
 		problem.Error(w, r, problem.Problem{Detail: err.Error()}, http.StatusInternalServerError)
@@ -124,9 +123,8 @@ func CheckPublicationByTitle(w http.ResponseWriter, r *http.Request, s IServer)
 	if pub, err := s.PublicationAPI().CheckByTitle(string(title)); err == nil {
 		enc := json.NewEncoder(w)
 		if err = enc.Encode(pub); err == nil {
-			// send json of correctly encoded user info
+			// send a json serialization of the boolean response
 			w.Header().Set("Content-Type", api.ContentType_JSON)
-			w.WriteHeader(http.StatusOK)
 			return
 		}
 		problem.Error(w, r, problem.Problem{Detail: err.Error()}, http.StatusInternalServerError)