Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update japanese message #690

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

toshiakikoike
Copy link

General Instructions

This pull request is a Work In Progress

Additional information

I add localized strings reference to en-US/message.json.
There are some strings remaind English.

@@ -1,10 +1,113 @@
{
"gitHasLocalChanges": {
"message": "with local changes"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this string be translated too?
You can see it in the "about" dialog bog (red text):
https://readium.firebaseapp.com
The message indicates that the local Git repository wasn't clean when the app was built.

"message" : "音を小さく"
},
"i18n_audio_time" : {
"message" : "Audio time cursor"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a message that could also be translated for "audio timeline". Is that easier to translate in Japanese?

@danielweck
Copy link
Member

Hello, thank you!
Could you please change the PR target from master to develop? (use the "edit" button)

@danielweck
Copy link
Member

I already posted a couple of comments (see above, inlined in this discussion thread).

However, there are a number of non-translated strings (still in English). Does this mean this PR is not ready yet? Or do you need help to clarify the meaning / usage in the User Interface?

@toshiakikoike toshiakikoike changed the base branch from master to develop March 7, 2018 01:24
add Japanese Translate
"message": "with local changes" 
"message" : "Audio time cursor"
"message" : "Loading Library"

and change PR target to develop
all messages translate to Japanese.
But because of the syntax difference with English and Japanese, some phrase  unnatural;

Close Table of Contents
-> 閉じる 目次
but natural Japanese are "目次を閉じる"

Word Text/audio synchronization granularity
-> 単語 同期の単位
but natural Japanese are "同期の単位:単語"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants