Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localized strings in reader-navbar.html for PT #261

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jon-moreira
Copy link
Contributor

Convert strings to translatable strings

Convert strings to translatable strings
@danielweck
Copy link
Member

Ah, the actual strings are missing:
https://github.com/readium/readium-js-viewer/blob/develop/src/i18n/_locales/en_US/messages.json
i18n_zoom_custom, i18n_zoom_fit_width, i18n_zoom_fit_screen

@rkwright rkwright removed bug labels May 7, 2016
@rkwright rkwright changed the title Update reader-navbar.html Update localized strings in reader-navbar.html for PT Jul 14, 2016
@danielweck
Copy link
Member

Hello, this is a good contribution (thank you), but the JSON file update is missing (to include the 3x new translated labels). Are you able to update your pull request? Kind regards, Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants